-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
dnswalk: add page #16968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnswalk: add page #16968
Conversation
DNS debugging tool from 16796. |
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're dealing with a short options only type of a command, we can go ahead and add mnemonics.
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have some suggestions regarding the wording and also found a few typos :)
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after the suggestions are applied
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Every time you merge main it sends an unnecessary email to all participants |
Sorry for that - thanks for flagging. |
@gutjuri can you please review changes? Thanks! |
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
Changed were made and we were waiting for re-review too long
common
,linux
,osx
,windows
,sunos
,android
, etc.