Skip to content

Conversation

KristopherLeads
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jun 26, 2025
@KristopherLeads
Copy link
Collaborator Author

DNS debugging tool from 16796.

@KristopherLeads KristopherLeads changed the title Create dnswalk.md dnswalk: add page Jun 26, 2025
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're dealing with a short options only type of a command, we can go ahead and add mnemonics.

KristopherLeads and others added 7 commits June 26, 2025 11:08
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions regarding the wording and also found a few typos :)

KristopherLeads and others added 8 commits June 29, 2025 10:14
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the suggestions are applied

Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
KristopherLeads and others added 6 commits July 1, 2025 07:55
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@KristopherLeads KristopherLeads requested a review from gutjuri July 1, 2025 15:13
@KristopherLeads KristopherLeads mentioned this pull request Jul 1, 2025
6 tasks
@Managor
Copy link
Member

Managor commented Jul 1, 2025

Every time you merge main it sends an unnecessary email to all participants

@KristopherLeads
Copy link
Collaborator Author

Every time you merge main it sends an unnecessary email to all participants

Sorry for that - thanks for flagging.

@KristopherLeads
Copy link
Collaborator Author

@gutjuri can you please review changes? Thanks!

@Managor Managor requested review from gutjuri and removed request for gutjuri July 3, 2025 17:58
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
@spageektti spageektti dismissed gutjuri’s stale review July 7, 2025 13:33

Changed were made and we were waiting for re-review too long

@spageektti spageektti merged commit a49cfcb into tldr-pages:main Jul 7, 2025
4 checks passed
@KristopherLeads KristopherLeads deleted the dnswalk-new branch July 7, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants